Skip to content

Split Fortran2008.py into separate files (closes #411)#425

Merged
arporter merged 9 commits intomasterfrom
411_split_file
Sep 14, 2023
Merged

Split Fortran2008.py into separate files (closes #411)#425
arporter merged 9 commits intomasterfrom
411_split_file

Conversation

@rupertford
Copy link
Collaborator

@rupertford rupertford commented Aug 3, 2023

Splits Fortran2008.py into one file per class.

@rupertford rupertford added in progress F2008 Relates to support for the Fortran 2008 standard labels Aug 3, 2023
@rupertford rupertford self-assigned this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (0d20a0d) 91.81% compared to head (359693f) 91.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   91.81%   91.91%   +0.10%     
==========================================
  Files          43       84      +41     
  Lines       13470    13625     +155     
==========================================
+ Hits        12367    12524     +157     
+ Misses       1103     1101       -2
Files Changed Coverage Δ
src/fparser/two/Fortran2008/__init__.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/action_stmt_c201.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/action_stmt_c816.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/action_stmt_c828.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/action_stmt_r214.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/alloc_opt_r627.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/allocate_stmt_r626.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/attr_spec_r502.py 100.00% <100.00%> (ø)
...rc/fparser/two/Fortran2008/block_construct_r807.py 100.00% <100.00%> (ø)
src/fparser/two/Fortran2008/block_stmt_r808.py 100.00% <100.00%> (ø)
... and 33 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rupertford
Copy link
Collaborator Author

rupertford commented Aug 3, 2023

Ready for first review from @arporter or @sergisiso

arporter
arporter requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've assumed that all you've done is move code to separate files so have not (well almost) requested changes to any of the content of those files.
However, I'm a bit worried by the splitparen shenanigans. Is it possible to get a handle on what's going wrong with that method?

@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Sep 11, 2023
@rupertford rupertford added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Sep 12, 2023
@rupertford
Copy link
Collaborator Author

rupertford commented Sep 12, 2023

You are correct that this PR simply splits out the classes from Fortran2008.py. Ready for next review from @arporter

arporter
arporter approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now.
Have tested with PSyclone and all fine.
Will proceed to merge.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Sep 14, 2023
@arporter arporter merged commit 2c8ed37 into master Sep 14, 2023
@arporter arporter deleted the 411_split_file branch September 14, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arporter arporter arporter approved these changes

Assignees

@rupertford rupertford

Labels

F2008 Relates to support for the Fortran 2008 standard ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rupertford @arporter