Fix namelist r552 matching error (closes #165)#415
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 91.75% 91.76%
=======================================
Files 37 37
Lines 13384 13387 +3
=======================================
+ Hits 12281 12284 +3
Misses 1103 1103
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Ready for first review from @arporter or @sergisiso |
arporter
approved these changes
May 15, 2023
Member
arporter
left a comment
There was a problem hiding this comment.
Looks good. Changes are pylint clean.
Coverage is all good.
This is a bug fix so no documentation update required.
Issue number is not mentioned anywhere.
Will proceed to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of namelist-stmt r552 in Fortran2003 (Namelist_Stmt) contained asserts in two places rather than returning None (which specifies no match). This PR fixes this error, tidies the code, tightens the implementation and adds tests that fully cover the code in the class.