Codecov Report

Merging #351 (fd35907) into master (ffee889) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          36       36           
  Lines       13047    13052    +5     
=======================================
+ Hits        11918    11923    +5     
  Misses       1129     1129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffee889...fd35907. Read the comment docs.

@TeranIvy this is the PR for the fparser fix. HEAD of PSyclone is fine with this branch and all of the NEMO source parses without errors. I've just tried it on LFRic too and it seems fine.

This is ready for review now.

Tested in the LFRic suite. All green: PSycloning, compilation, runs, style checks and KGO checks.

Tested in the LFRic suite. All green: PSycloning, compilation, runs, style checks and KGO checks.

Hi @TeranIvy, was that with HEAD of PSyclone master?

Tested in the LFRic suite. All green: PSycloning, compilation, runs, style checks and KGO checks.

Hi @TeranIvy, was that with HEAD of PSyclone master?

Yes, @arporter, with the head of PSyclone master. I created a PSyclone branch from the head of master with the fparser submodule from this branch and then I installed PSyclone test environment from that.

BTW, that was yesterday (15 June) evening. I see that there is a fresh merge to head. Shall I test it again?

@TeranIvy The last changes shouldn't change LFRic behavior but do touch the base classes that LFRic use. So it would be safer to test again.