Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 91.33% 91.28% -0.06%
==========================================
Files 36 36
Lines 13163 13046 -117
==========================================
- Hits 12023 11909 -114
+ Misses 1140 1137 -3
Continue to review full report at Codecov.
|
Member
Author
|
I have some coverage issues but precisely what with is hard to say as CodeCov is currently refusing to show me the annotated source files. |
Member
Author
|
Finally dealt with the newly-uncovered lines. Also took the opportunity to fix (some of) the low-hanging pylint complaints. |
This was referenced Apr 6, 2022
Closed
rupertford
suggested changes
May 3, 2022
Collaborator
rupertford
left a comment
There was a problem hiding this comment.
Looks good. Comments are inline. Could you also grep for import six and remove where appropriate as there seem to be quite a few of these left in the code.
Member
Author
|
Ready for next review from @rupertford. Discovered that we're supposed to specify Python versions in quotes in the GHA yml file (actions/setup-python#160). |
rupertford
approved these changes
May 9, 2022
Collaborator
rupertford
left a comment
There was a problem hiding this comment.
All issues have been addressed. Approving.
ZedThree
added a commit
that referenced
this pull request
May 10, 2022
* master: pr #322. Updated changelog ready for merge to master. #322 try quoting python versions in GHA yml #322 updates for review #323 update changelog Use Sphinx roles to some docstrings Add some test docstrings Move entity decl test under f2003 directory Auto-use parser creation fixtures Add more tests for `get_name` methods Add `.get_name()` to `Function_Stmt` and `Entity_Decl`
ZedThree
added a commit
that referenced
this pull request
May 10, 2022
* master: pr #322. Updated changelog ready for merge to master. #322 try quoting python versions in GHA yml #322 updates for review #323 update changelog Use Sphinx roles to some docstrings Add some test docstrings Move entity decl test under f2003 directory Auto-use parser creation fixtures Add more tests for `get_name` methods Add `.get_name()` to `Function_Stmt` and `Entity_Decl`
ZedThree
added a commit
that referenced
this pull request
May 11, 2022
* master: pr #322. Updated changelog ready for merge to master. #322 try quoting python versions in GHA yml #322 updates for review #323 update changelog Use Sphinx roles to some docstrings Add some test docstrings Move entity decl test under f2003 directory Auto-use parser creation fixtures Add more tests for `get_name` methods Add `.get_name()` to `Function_Stmt` and `Entity_Decl` #322 rm py2-specific code from Fortran2003.py #322 fix-up coverage and tidy some pylint issues #322 fix links and formatting in dev guide #322 update dev guide #322 remove the make_clean_tmpfile utility and associated tests #307 change GHA to run with python 3.6, 3.8 and 3.10
ZedThree
added a commit
to PlasmaFAIR/fparser
that referenced
this pull request
Jun 9, 2022
* master: (44 commits) stfc#336 update changelog stfc#343 update version to 0.0.15 Update changelog stfc#328 update changelog Rename `BeginStatement.handle_unknown_item` Return `None` from unimplemented function Use `f` prefix on all lines of multiline f-string Return `None` explicitly from some functions Remove redundant `return` statements from the end of functions Convert some `str.format()` calls to f-strings Remove py2 `unicode` string literal Remove py2 `unicode` special handling Change type in docstring to py3 style hint Remove reference to py2 from comments/docstring Revert accidental removal of test case Fix wrong variable in error message Remove duplicated `str` in `isinstance` argument pr stfc#322. Updated changelog ready for merge to master. stfc#322 try quoting python versions in GHA yml stfc#322 updates for review ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.