(Closes #310) allow for current_scope to be None and extend tests#311
Merged
rupertford merged 5 commits intomasterfrom Mar 15, 2022
Merged
(Closes #310) allow for current_scope to be None and extend tests#311rupertford merged 5 commits intomasterfrom
rupertford merged 5 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 91.09% 91.11% +0.02%
==========================================
Files 36 36
Lines 13107 13108 +1
==========================================
+ Hits 11940 11944 +4
+ Misses 1167 1164 -3
Continue to review full report at Codecov.
|
Member
Author
|
Ready for review from either @sergisiso or @rupertford. |
rupertford
suggested changes
Feb 9, 2022
Collaborator
rupertford
left a comment
There was a problem hiding this comment.
Nice job. I've just requested a few more tests for the changes to Fortran2003.py
Member
Author
|
Ready for another look now. |
Member
Author
|
Ready for another look now @rupertford. |
rupertford
approved these changes
Mar 15, 2022
Collaborator
rupertford
left a comment
There was a problem hiding this comment.
All looks good. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.