Changed number of expected arguments for intrinsic function IBITS to 3#241
Merged
rupertford merged 1 commit intostfc:masterfrom Feb 6, 2020
Merged
Changed number of expected arguments for intrinsic function IBITS to 3#241rupertford merged 1 commit intostfc:masterfrom
rupertford merged 1 commit intostfc:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 34 34
Lines 12108 12108
=======================================
Hits 10923 10923
Misses 1185 1185
Continue to review full report at Codecov.
|
rupertford
approved these changes
Feb 6, 2020
Collaborator
rupertford
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I confirm that the standard specifies 3 arguments. We don't explicitly test the number of arguments of individual intrinsics so there is no need to update any tests.
rupertford
added a commit
that referenced
this pull request
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intrinsic function
IBITS(I, POS, LEN)should expect exactly 3 arguments, fparser required it to have exactly 2.Reference: https://j3-fortran.org/doc/year/04/04-007.pdf#page=312
Page 312, Line 24