Update operator infrastructure and change use statements for CMA operators (for #1738)#1740
Update operator infrastructure and change use statements for CMA operators (for #1738)#1740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 250 250
Lines 37854 37858 +4
=======================================
+ Hits 37623 37627 +4
Misses 231 231
Continue to review full report at Codecov.
|
arporter
left a comment
There was a problem hiding this comment.
Great job Iva, I only have one small request.
All examples, tests and tutorials are OK with compilation.
Updated UG builds fine.
Does this branch work OK with LFRic?
|
Assuming the CI is green, is this ready for review again @TeranIvy? |
|
I am just testing this with LFRic, @arporter, so I will return it as soon as the test suite is done. |
|
I built the PSyclone test environment from this branch on Spice and Crays XC40 and XCS. I then ran an LFRic test branch that has all the changes for PSyclone 2.3.0 implemented (see LFRic ticket 3288, comment 6). The developer test suites were all fine. This PR ready to go so I am returning it to @arporter for another look. |
arporter
left a comment
There was a problem hiding this comment.
All requested changes have been made.
Tests and examples are still OK with compilation.
Proceeding to merge.
columnwise_matrix) tor_solverin test kernels and examples.operator_modfor CMA operator and operator proxy types and adds the use ofcolumnwise_operator_mod.