Skip to content

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option#16

Closed
stephenxs wants to merge 2 commits intomasterfrom
not-poll-bulk-init
Closed

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option#16
stephenxs wants to merge 2 commits intomasterfrom
not-poll-bulk-init

Conversation

@stephenxs
Copy link
Copy Markdown
Owner

@stephenxs stephenxs commented Sep 30, 2024

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option

  1. Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups
  2. Generate CLI options to syncd
  3. Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review September 30, 2024 09:36
Copy link
Copy Markdown

@DavidZagury DavidZagury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix missing function

@stephenxs
Copy link
Copy Markdown
Owner Author

ci 4481 + rerun 587 passed

@stephenxs
Copy link
Copy Markdown
Owner Author

ci 4519 passed

…s supported

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Copy Markdown
Owner Author

Force push to squash and avoid conflict.

@stephenxs stephenxs closed this Oct 20, 2024
stephenxs pushed a commit that referenced this pull request Feb 27, 2025
…#16)

```<br>* f091cdb9 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-sairedis into 202412 (2025-02-21) [Sonic Automation]
* d884ff9 - (origin/202411) [syncd] Move logSet logGet under mutex to prevent race condition (sonic-net#1520) (sonic-net#1538) (2025-02-20) [Kamil Cudnik]
* ec8b3c3 - Fix pipeline errors related to rsyslogd and libswsscommon installation (sonic-net#1535) (2025-02-19) [mssonicbld]
* 6b263b8 - [FC] Support Policer Counter (sonic-net#1533) (2025-02-19) [mssonicbld]
* e53489e - [syncd] Update log level for bulk api (sonic-net#1532) (2025-02-18) [Jianyue Wu]
* 7ae00e5 - Define bulk chunk size and bulk chunk size per counter ID (sonic-net#1528) (2025-02-11) [mssonicbld]
* f35e743 - [nvidia] Skip SAI discovery on ports (sonic-net#1524) (2025-02-07) [mssonicbld]
* bf049ed - Use sonictest pool instead of sonic-common and fix arm64 issue. (sonic-net#1516) (2025-02-05) [mssonicbld]
* ffe371d - [syncd] Support bulk set in INIT_VIEW mode (sonic-net#1517) (2025-02-05) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants