Conversation
3f5d631 to
f8a71e1
Compare
1. Enhance the diagnosis information collecting mechanism - If the option `-v` is fed, it will pass additional diagnosis flags to mlxfwmanager - Collect all the output from mlxfwmanager and print them to syslog if it fails 2. Abort syncd in case waiting for device or upgrading firmware fails Signed-off-by: Stephen Sun <stephens@nvidia.com>
f8a71e1 to
4a840f2
Compare
|
close this one since the one to master has been opened #146 |
| ;; | ||
| -v|--verbose) | ||
| VERBOSE_LEVEL="${VERBOSE_MAX}" | ||
| MFT_DIAGNOSIS_FLAGS="FLASH_ACCESS_DEBUG=1 FW_COMPS_DEBUG=1" |
There was a problem hiding this comment.
@stephenxs imo, this is not a verbose mode but rather a debug mode. Suggest having a separate key
There was a problem hiding this comment.
hi @nazariig
thanks for the comments. we discussed it with the team and decided to keep it as it is because we need to log all messages when MFT tool fails and it doesn't bring benefit to introduce a new option.
There was a problem hiding this comment.
@stephenxs isn't it add a kind of overhead for normal operations? I remember that there were concerns to have it enabled by default
There was a problem hiding this comment.
@nazariig
yes. at least, it prints more with the options. but according to MFT team, it "won't be too long".
can you remind me what the concern is? maybe taking more time in fast/warm reboot?
…lly (sonic-net#16228) #### Why I did it src/sonic-gnmi ``` * ac94807 - (HEAD -> master, origin/master, origin/HEAD) Support get all with json (#145) (19 hours ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog
…utomatically (sonic-net#19897) #### Why I did it src/sonic-host-services ``` * 39e31a9 - (HEAD -> master, origin/master, origin/HEAD) Fix modify_single_file generate empty file issue (#145) (26 hours ago) [Hua Liu] * 1891b0a - Add dbus service to read file stat (#142) (2 days ago) [isabelmsft] ``` #### How I did it #### How to verify it #### Description for the changelog
…utomatically (sonic-net#20043) #### Why I did it src/sonic-host-services ``` * 4fb94d1 - (HEAD -> 202311, origin/202311) Fix modify_single_file generate empty file issue (#145) (9 minutes ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
Why I did it
-vis fed, it will pass additional diagnosis flags to mlxfwmanagerWork item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)