[Nvidia] Use Debian reboot in Nvidia platform reboot when it is invoked from kdump capture boot#141
Closed
[Nvidia] Use Debian reboot in Nvidia platform reboot when it is invoked from kdump capture boot#141
Conversation
Junchao-Mellanox
approved these changes
Jul 3, 2023
Junchao-Mellanox
approved these changes
Jul 4, 2023
c434d90 to
82dfcf4
Compare
The kdump capture boot is to record and store a kernel crash only. In this boot, no SONiC service is loaded. But Nvidia platform reboot depends on hw-management service which is part of SONiC service In this case, we should use Debian reboot Signed-off-by: Stephen Sun <stephens@nvidia.com>
82dfcf4 to
d122ce6
Compare
Owner
Author
|
ci 2772 passed. |
stephenxs
pushed a commit
that referenced
this pull request
Aug 10, 2023
…lly (sonic-net#16024) #### Why I did it src/sonic-gnmi ``` * c548cc2 - (HEAD -> master, origin/master, origin/HEAD) Support empty protobytes (#141) (2 hours ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog
stephenxs
pushed a commit
that referenced
this pull request
Dec 26, 2023
…matically (sonic-net#15777) src/sonic-py-swsssdk * 1109e49 - (HEAD -> 202305, origin/master, origin/HEAD, origin/202305, master) add semgrep (#141) (4 weeks ago) [Mai Bui] How I did it How to verify it
stephenxs
pushed a commit
that referenced
this pull request
May 6, 2024
…automatically (sonic-net#18856) #### Why I did it src/sonic-mgmt-framework ``` * 2248203 - (HEAD -> master, origin/master, origin/HEAD) Adding go.mod and go.sum files to resolve build issues. (#141) (2 days ago) [Nikita Agarwal] ``` #### How I did it #### How to verify it #### Description for the changelog
stephenxs
pushed a commit
that referenced
this pull request
May 31, 2024
…omatically (sonic-net#19119) #### Why I did it src/sonic-mgmt-common ``` * 8b18795 - (HEAD -> master, origin/master, origin/HEAD) fix for the nil check in the subscribe request (#141) (6 hours ago) [Balachandar Mani] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When a kernel crash occurs, the system will reboot to the kdump capture kernel if kdump is enabled (
config kdump enable). In the kdump capture boot, it only stores the crash information, and then reboot the system to a normal boot.In this boot, no SONiC service is started but it invokes
rebootwhich is actually the SONiC reboot that depends on SONiC services. There is a logic to skip all SONiC stuff and invoke platform reboot in SONiC reboot to avoid issues.However, on Nvidia platforms, the platform reboot still depends on SONiC services, which can cause issues.
So, the Debian reboot is called directly in platform reboot if it is invoked from the kdump capture boot.
Work item tracking
How I did it
How to verify it
Manual test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)