docs(support): add entry for typescript 5 to support policy#1117
Merged
alicewriteswrongs merged 2 commits intomainfrom May 22, 2023
Merged
docs(support): add entry for typescript 5 to support policy#1117alicewriteswrongs merged 2 commits intomainfrom
alicewriteswrongs merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
14 tasks
rwaskiewicz
approved these changes
May 17, 2023
tanner-reits
approved these changes
May 18, 2023
32a8fc1 to
3fc79b2
Compare
alicewriteswrongs
added a commit
to stenciljs/core
that referenced
this pull request
May 22, 2023
This upgrades the version of TypeScript bundled with Stencil to 5.0.4. In order to support the upgrade we have to do a few things: - edit the Rollup plugin we use to bundle typescript to account for changes in how typescript is bundled now (this changed for the 5.0.0 release) - fix tests which assert on e.g. transformer output to account for small, mostly one-character differences in output with the strings we have in tests - move the location where we prevent `.d.ts` files being written to disk during `stencil build` for test files See also a documentation PR here: stenciljs/site#1117 It was also necessary to make a few tweaks to how the Karma tests are run to account for some changes in how TypeScript resolves modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentation for stenciljs/core#4315