Feature/required inputs#673
Conversation
Adapt the component arguments to pass information on required inputs.
Processing of required inputs. Keep the order, but instead of specify only name, define it as object with required property set to true.
|
Hello! Instead of passing two separate input parameters, please modify the existing input param type from string[], to a newly created interface called InputProperty (or something like that) having a name: string and required: boolean as fields. This change would make it easier to read and understand, while also adding the ability for future input property extensions |
|
@gratzl-dev I adapted a little code. Can you tell me if the types.ts is a good place for this new interface ? |
Yes, these are the built files in the example project. This is required for the tests. |
…objects when used without compare callback. + prettier
… tests for required inputs.
|
Tests should pass in CI now. Can you review code quality ? |
|
@mklemarczyk mind running |
|
@gratzl-dev mind taking another look? Would love to get your 👍 as well! |
|
@christian-bromann I do not get it. I run it and it pass locally. I do not have any modification I could commit. |
|
Looks good 👍 |
* Upgrade to get Angular [required inputs](stenciljs/output-targets#673) * Remove a dubiously-required, actually dead input on `<biggive-text-input/>` * `npm update` generally
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #656
What is the new behavior?
Does this introduce a breaking change?
Other information