chore(types): update browser-compile typings#3280
Merged
rwaskiewicz merged 1 commit intomainfrom Mar 15, 2022
Merged
Conversation
this commit introduces proper type guards for the browser-compile project, removing the stopgap 'any' usage that was introduced in #3259
ltm
approved these changes
Mar 15, 2022
rwaskiewicz
added a commit
that referenced
this pull request
Mar 24, 2022
this commit introduces proper type guards for the browser-compile project, removing the stopgap 'any' usage that was introduced in #3259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
In #3259, we typed an error as
type
anyas a stopgap measure to allow publishes to occur again. This pieceof debt was left for a future day (which is today).
GitHub Issue Number: N/A
What is the new behavior?
this commit introduces proper type guards for the browser-compile
project, removing the stopgap 'any' usage that was introduced in
#3259
Does this introduce a breaking change?
Testing
In this branch, navigate to
test/browser-compileand:npm run buildto test production buildsnpm startto smoke test the applicationOther information