Skip to content

chore(types): update browser-compile typings#3280

Merged
rwaskiewicz merged 1 commit intomainfrom
rwaskiewicz/unknown-browser-compile
Mar 15, 2022
Merged

chore(types): update browser-compile typings#3280
rwaskiewicz merged 1 commit intomainfrom
rwaskiewicz/unknown-browser-compile

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

@rwaskiewicz rwaskiewicz commented Mar 11, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In #3259, we typed an error as
type any as a stopgap measure to allow publishes to occur again. This piece
of debt was left for a future day (which is today).

GitHub Issue Number: N/A

What is the new behavior?

this commit introduces proper type guards for the browser-compile
project, removing the stopgap 'any' usage that was introduced in
#3259

Does this introduce a breaking change?

  • Yes
  • No

Testing

In this branch, navigate to test/browser-compile and:

  • npm run build to test production builds
  • npm start to smoke test the application

Other information

this commit introduces proper type guards for the browser-compile
project, removing the stopgap 'any' usage that was introduced in
#3259
@rwaskiewicz rwaskiewicz marked this pull request as ready for review March 11, 2022 15:05
@rwaskiewicz rwaskiewicz requested a review from a team March 11, 2022 15:05
@rwaskiewicz rwaskiewicz merged commit edd1776 into main Mar 15, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/unknown-browser-compile branch March 15, 2022 16:22
rwaskiewicz added a commit that referenced this pull request Mar 24, 2022
this commit introduces proper type guards for the browser-compile
project, removing the stopgap 'any' usage that was introduced in
#3259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants