chore(fixups): minor sourcemap fixups#3078
Merged
rwaskiewicz merged 6 commits intorwaskiewicz-rebase-again-sourcemapsfrom Sep 23, 2021
Merged
chore(fixups): minor sourcemap fixups#3078rwaskiewicz merged 6 commits intorwaskiewicz-rebase-again-sourcemapsfrom
rwaskiewicz merged 6 commits intorwaskiewicz-rebase-again-sourcemapsfrom
Conversation
this commit adds additional tyings to `generateRollupOutput` to help make it easier to understand the map() function call that is invoked on the results of calling `build.generate()`
is an optional property on rollup source maps, update our representation
extract the labels used in timespans to variables, to make it less likely we'll mess up their content in two different callsites this commit also adds return types to the methods updated
splitinfinities
approved these changes
Sep 23, 2021
Contributor
splitinfinities
left a comment
There was a problem hiding this comment.
Only one non-blocking bit of feedback
| await Promise.all(outputTargets.map((o) => bundleCustomElements(config, compilerCtx, buildCtx, o))); | ||
|
|
||
| timespan.finish(`generate custom elements finished`); | ||
| timespan.finish(bundlingEventMessage); |
Contributor
There was a problem hiding this comment.
Should this be similar to this? https://github.com/ionic-team/stencil/pull/3078/files#diff-db8331cc26cc3aca3d77bb2dbd81e8f595b9f7e669cfa9d083b9b54b3e57820fR40
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
this commit adds additional typings to `generateRollupOutput` to help make it easier to understand the map() function call that is invoked on the results of calling `build.generate()` sourcemap is an optional property on rollup source maps, update our representation extract the labels used in timespans to variables, to make it less likely we'll mess up their content in two different callsites this commit also adds return types to the methods updated
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
this commit adds additional typings to `generateRollupOutput` to help make it easier to understand the map() function call that is invoked on the results of calling `build.generate()` sourcemap is an optional property on rollup source maps, update our representation extract the labels used in timespans to variables, to make it less likely we'll mess up their content in two different callsites this commit also adds return types to the methods updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
This PR performs 4 minor refactorings, each confined to their own commit. Each seemed too small to put in their own PR, hence one with the separate commits
GitHub Issue Number: N/A
What is the new behavior?
generateRollupOutputto help make it easier to understand the map() function call that is invoked on the results of callingbuild.generate()mapproperty on our sourcemap representation to optional, match sourcemapsDoes this introduce a breaking change?
Testing
Smoke tested locally
Other information