refactor(validate-tsconfig-tests): refactor tsconfig tests#3036
Merged
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom Aug 30, 2021
Merged
Conversation
this commit refactors & renames `src/compiler/config/test/validate-ts-sourcemap.spec.ts` to `src/compiler/config/test/validate-config-sourcemap.spec.ts` the file was renamed to align with the unit test file `validate-config.spec.ts`, found in the same directory. This file was not merged with `validate-config.spec.ts` to avoid more refactoring than necessary. the refactoring of the test file consists of: - renaming the suite & associated tests for clarity - removing unnecessary filesystem calls - refactoring generating a `LoadConfigInit` entity out to a helper fn - variable renaming
ltm
approved these changes
Aug 30, 2021
rwaskiewicz
added a commit
that referenced
this pull request
Sep 20, 2021
this commit refactors & renames `src/compiler/config/test/validate-ts-sourcemap.spec.ts` to `src/compiler/config/test/validate-config-sourcemap.spec.ts` the file was renamed to align with the unit test file `validate-config.spec.ts`, found in the same directory. This file was not merged with `validate-config.spec.ts` to avoid more refactoring than necessary. the refactoring of the test file consists of: - renaming the suite & associated tests for clarity - removing unnecessary filesystem calls - refactoring generating a `LoadConfigInit` entity out to a helper fn - variable renaming
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
…#3036) this commit refactors & renames `src/compiler/config/test/validate-ts-sourcemap.spec.ts` to `src/compiler/config/test/validate-config-sourcemap.spec.ts` the file was renamed to align with the unit test file `validate-config.spec.ts`, found in the same directory. This file was not merged with `validate-config.spec.ts` to avoid more refactoring than necessary. the refactoring of the test file consists of: - renaming the suite & associated tests for clarity - removing unnecessary filesystem calls - refactoring generating a `LoadConfigInit` entity out to a helper fn - variable renaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit refactors & renames
src/compiler/config/test/validate-ts-sourcemap.spec.tstosrc/compiler/config/test/validate-config-sourcemap.spec.tsthis test targets https://github.com/ionic-team/stencil/pull/3005/files#diff-53c120bef3205f89229fbe98a5aadfcb51012ead144729ade2fc597c1e9ad5e9R48
the file was renamed to align with the unit test file
validate-config.spec.ts, found in the same directory. This file wasnot merged with
validate-config.spec.tsto avoid more refactoring thannecessary.
the refactoring of the test file consists of:
LoadConfigInitentity out to a helper fn