chore(config): coerce sourceMap config value to boolean #3035
Merged
rwaskiewicz merged 2 commits intorwaskiewicz-rebase-again-sourcemapsfrom Aug 30, 2021
Merged
chore(config): coerce sourceMap config value to boolean #3035rwaskiewicz merged 2 commits intorwaskiewicz-rebase-again-sourcemapsfrom
rwaskiewicz merged 2 commits intorwaskiewicz-rebase-again-sourcemapsfrom
Conversation
ensure that upon validating a user's stencil config, the value of the 'sourcemap' field is never undefined. to appease the type system
ltm
reviewed
Aug 27, 2021
ltm
approved these changes
Aug 30, 2021
rwaskiewicz
added a commit
that referenced
this pull request
Sep 20, 2021
ensure that upon validating a user's stencil config, the value of the 'sourcemap' field is never undefined. remove unneeded 'bang bang' operators after forcing souremap to boolean
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
ensure that upon validating a user's stencil config, the value of the 'sourcemap' field is never undefined. remove unneeded 'bang bang' operators after forcing souremap to boolean
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
ensure that upon validating a user's stencil config, the value of the 'sourcemap' field is never undefined. remove unneeded 'bang bang' operators after forcing souremap to boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run test.karma.prod) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
config.sourcemapcan be eitherundefined | true | falsewhen a user's configuration is validated. I'd prefer to narrow that to a boolean, even if we don't strictly do that using the type system right now. See this comment in the parent PR that expounds upon thisGitHub Issue Number: N/A
What is the new behavior?
ensure that upon validating a user's stencil config, the value of the
'sourcemap' field is never undefined.
Does this introduce a breaking change?
Testing
After checking this commit out, I:
npm ci)npm run build && npm pack)npm stencil init && npm i <PATH_TO_TARBALL>)npm start)Other information
N/A