chore(sourcemaps): simplify transformation of sourcemaps#3026
Merged
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom Aug 25, 2021
Merged
Conversation
simplify the transformation of sourcemaps by removing code paths that I don't believe will be followed. add tests to the sourcemaps utility function
splitinfinities
approved these changes
Aug 25, 2021
Contributor
splitinfinities
left a comment
There was a problem hiding this comment.
I'd like to understand the purpose behind the return signature a little better, but I don't have any blocking changes. I appreciate the readability and how much more straight-forward the resultant object became.
Member
Author
|
@splitinfinities LMK if I answered your question sufficiently in the comments, happy to elaborate if not |
Contributor
|
@rwaskiewicz it all makes sense to me now 👍 |
rwaskiewicz
added a commit
that referenced
this pull request
Aug 27, 2021
simplify the transformation of sourcemaps by removing code paths that I don't believe will be followed. add tests to the sourcemaps utility function
rwaskiewicz
added a commit
that referenced
this pull request
Sep 20, 2021
simplify the transformation of sourcemaps by removing code paths that I don't believe will be followed. add tests to the sourcemaps utility function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run test.karma.prod) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
simplify the transformation of sourcemaps by removing code paths that I
don't believe will be followed.
GitHub Issue Number: N/A
What is the new behavior?
do a 1:1 mapping of the rollup representation of a sourcemap to a Stencil one. I did briefly consider removing this altogether, but I think that there's value in having our own representation/abstraction to mitigate any damage that could be caused by the typings of a sourcemap in rollup occurring
Does this introduce a breaking change?
Testing
After checking this commit out, I:
npm ci)npm run build && npm pack)npm stencil init && npm i <PATH_TO_TARBALL>)npm start)Other information
N/A