docs(license): add adr for license attribution#3017
Merged
rwaskiewicz merged 2 commits intomasterfrom Aug 24, 2021
Merged
Conversation
splitinfinities
approved these changes
Aug 23, 2021
docs/adr/0008-license-attribution.md
Outdated
|
|
||
| ## Links | ||
|
|
||
| Source: [https://adr.github.io/](https://adr.github.io/) |
Contributor
There was a problem hiding this comment.
Nix the links section as it's not necessary on this ADR.
|
|
||
| ## Decision | ||
|
|
||
| Third party scripts that are included in the Stencil output shall be placed in the `entryDeps` field in a |
Contributor
There was a problem hiding this comment.
This is all great to know, thank you for spelling it out so plainly. Up until now, I had no idea about this.
add an ADR describing how third party projects that are bundled in the Stencil distributable should be attributed. I confirmed this practice with Adam as a part of #3016.
0a10f96 to
0d3311f
Compare
rwaskiewicz
added a commit
that referenced
this pull request
Aug 27, 2021
add an ADR describing how third party projects that are bundled in the Stencil distributable should be attributed. I confirmed this practice with Adam as a part of #3016.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add an ADR describing how third party projects that are bundled in the
Stencil distributable should be attributed. I confirmed this practice
with Adam as a part of #3016.