Closed
Conversation
Subscribing
get latest changes from ionic
|
any chance this can be merged @adamdbradley ? cheers |
1 task
This was referenced Nov 7, 2021
Member
|
Thanks @Tallyb! I've been working on Jest 27 support in Stencil, where the work needed to support v27 is split between 2 separate PRs:
I'm going to close this PR as it is superseded by those two PRs I listed above. I expect the first of the two to land in time for the next minor version of Stencil. Thank you again! |
14 tasks
Contributor
Author
|
thanks. it seems to be working fine: Tallyb/stencil-one#258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCacheKey signature was changed in jest 27.
Fix is implemented for backward compatibility so it can work with both 26 and 27.