Conversation
rwaskiewicz
pushed a commit
that referenced
this pull request
Aug 17, 2021
2 tasks
3 tasks
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 16, 2025
Add WDIO tests rendering all <prop-…> components plus behavior checks for reflect=true/false (string/number/boolean) Prop overlay: emit stable caseIds (#1 primitives, #2 complex, #3 reflect=true primitives, stenciljs#4 reflect=false primitives); 100% detection via JSX scan @Prop.mdx: switch Test Cases to single-row-per-case (#1–stenciljs#4), drive “Tested By” from caseIds Add placeholder rows for stenciljs#5 (mutable=true primitives) and stenciljs#6 (mutable=false primitives); show neutral status until implemented Status logic: avoid checkmarks for unimplemented cases (render em dash) AGENT_PROMPTS: replace with concise, copy-paste prompts to “Implement Test Case stenciljs#5/stenciljs#6 for the @prop decorator”; clarify “re-run Prop test-coverage.js” wording
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 20, 2025
Wrap @State specs into describe blocks: Test Case #1 – Primitive mutation Test Case #2 – Complex static render Move/rename file from components.test.tsx to tests.tsx Update State coverage script to scan test/wdio/state (folder root) Extend test source collector to include a root-level tests.tsx (in addition to .test.) Update @State docs note to reference test/wdio/state Keep JSX render with targeted ts-ignore for WDIO browser-runner compatibility
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 20, 2025
Organize @prop WDIO specs into describe blocks per Test Case (#1–stenciljs#5) Move/rename test from components.test.tsx to tests.tsx Update Prop coverage script to scan test/wdio/prop (folder root) Ensure test source collector includes root-level tests.tsx docs(prop): update note to reference test/wdio/prop
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 20, 2025
…to AI memories - Add test-case-conventions.md documenting AI-friendly structured test patterns - Document @State test cases: #1 Primitive mutation, #2 Complex static render - Document @prop test cases: #1-5 covering runtime, complex render, reflect/mutable behaviors - Include complete matrix rendering patterns with WebDriver IO assertion examples - Add component tag naming conventions and predictable DOM structure expectations - Update memory-sync.js to include test case conventions in synchronization (high priority) - Update README.md structure to include test-case-conventions.md file - Update conventions.md with references to structured test case patterns - Sync all memories to IDE including new test case conventions documentation This completes the AI context system by documenting the existing sophisticated test case patterns that enable easy test generation, extension, and maintenance across the 289-component testing framework.
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 22, 2025
…ate tests - **Structure**: Move components from matrix/ to components/ with bubbles/no-bubbles subdirs - **File organization**: Create data/ subdirectory for rules.json, components.json, test-coverage.json - **Scripts**: - Update generate-components.js to integrate runVerifier and add --force flag support - Rename coverage.js → test-coverage.js with proper test file analysis and caseIds assignment - Remove obsolete verify-matrix.js and coverage-overlay.json files - **Tests**: - Move and rename tests/cmp.test.tsx → tests.tsx for WDIO pattern compliance - Organize into logical test cases: "Bubbling events" vs "Non-bubbling events" - Integrate 8 @event tests into main test suite (now 40/40 tests passing) - **Documentation**: - Update @Event.mdx to use shared TestCasesTable and GeneratedComponentsTable - Fix test cases table to show implemented status with proper coverage data - Populate "Tested By" column with case numbers (#1, #2) in components table - **NPM scripts**: Add event:generate-components:force and event:test-coverage patterns
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 22, 2025
Create shared infrastructure and simplify component generation workflow across @Prop/@State/@Method/@event decorators for better maintainability and DX. **Shared Infrastructure**: - Add `_shared/generate-components-core.js` (164 lines) handling all common logic - Eliminate 179 lines of duplicated code across 4 decorator scripts - Single source of truth for help, setup, generation, and verification **Simplified Approach**: - Always generate all components (no more complex missing/force logic) - Remove --force flag complexity - generation is now deterministic and fast - Clean help text: "Generates all components (overwrites existing files)" - Reduce npm scripts from 12 to 6 (remove all :force variants) **Script Modernization**: - @prop: 283→233 lines (18% reduction) - @State: 261→236 lines (10% reduction) - @method: 246→194 lines (21% reduction) - @event: 211→159 lines (25% reduction) **Developer Experience**: - ✅ Consistent behavior across all decorators - ✅ No more "forgot --force" errors (eliminated #1 pain point) - ✅ Deterministic output - same input always produces same result - ✅ Fast generation (~0.1s per decorator) - ✅ Simplified commands and help text **Benefits**: - Single code path eliminates branching complexity - Bug fixes and enhancements automatically apply to all decorators - Future decorator refactoring inherits all improvements - Components always match current templates (no sync issues) Ready for @listen and @component modernization using same proven patterns.
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Oct 27, 2025
paulvisciano
referenced
this pull request
in paulvisciano/stencil-core
Nov 20, 2025
test(@component): implement Test Case #1 (Shadow DOM mode) - Add WDIO tests covering shadow root, styles, formAssociated, and assetsDirs - Include all 48 shadow mode components in test template - Fix invalid tag name in cmp.tsx (cmp -> cmp-light) - Enhance query-missing-tests.js with detailed stats ```
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Add a test demonstrating how you can use extends to directly manage state as part of your baseClass * Extend Tests for @method decorator inheritance, super() calls, method override, and method composition. * Extend Tests for @prop and @State inheritance from base classes. * Extend Tests for extending Stencil-decorated classes with render() method inheritance. * Demonstrates base classes triggering host component updates via requestUpdate * Tests demonstrating lifecycle hooks living on the base class * Tests for multi-level lifecycle inheritance * Tests for ReactiveControllerHost pattern - composition based controllers with automatic lifecycle hooking * Run prettier --------- Co-authored-by: John Jenkins <johnljenkins@Hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.