key and ref for all JSX elements#2925
key and ref for all JSX elements#2925kraftwer1 wants to merge 1 commit intostenciljs:masterfrom kraftwer1:patch-3
Conversation
Every element that is generated by JSX can have a key or a ref attribute.
This allows, for example: `<slot ref={(el) => this.slotEl = el />`
|
@rwaskiewicz any comments on why you've closed this? Thanks. |
|
@kraftwer1 I'm not sure what happened here. Around that time I moved Stencil's primary branch from using 'master' to 'main' naming, and it looks like the issue was closed on the same/date time 🤔 My understanding was that GitHub would not be closing open PRs. So I'd guess one of two things happened here:
Either way this shouldn't have been closed. Let me reopen it and make sure nothing else got closed on that date. Sorry about that! |
|
@kraftwer1 odd...for some reason only this PR was closed when #3096 was merged (to make the switch from |
|
Hi @rwaskiewicz thanks for your quick response. No problem, here's the new one: |
Every element that is generated by JSX can have a key or a ref attribute.
This allows, for example:
<slot ref={(el) => this.slotEl = el} />