Skip to content

chore(git): rename master branch references to main#3096

Merged
rwaskiewicz merged 4 commits intomainfrom
rwaskiewicz/rename-master-to-main-in-core
Oct 7, 2021
Merged

chore(git): rename master branch references to main#3096
rwaskiewicz merged 4 commits intomainfrom
rwaskiewicz/rename-master-to-main-in-core

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

@rwaskiewicz rwaskiewicz commented Oct 6, 2021

DO NOT MERGE YET

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Today, the primary branch in Stencil Core is named 'master'. Although GitHub has tooling around moving the primary branch (renaming it), it doesn't fix all the hardcoded references in the codebase.

GitHub Issue Number: N/A

What is the new behavior?

update all references to the code of conduct and contributing guidelines
to use 'main' instead of 'master'

update github workflows to use main instead of master

update the release notes tooling

Does this introduce a breaking change?

  • Yes
  • No

Testing

There are two things I could not test that could break

  1. GitHub workflows - since we haven't renamed the branch yet, it's hard to tell if this 'just works'. However, I am confident that if it breaks, we'll know very quickly 😉
  2. Release tooling - likewise with workflows. If this breaks, this is pretty easy to work around with the any-branch flag

Other information

@rwaskiewicz rwaskiewicz changed the title Rwaskiewicz/rename master to main in core chore(git): rename master branch references to main Oct 6, 2021
Copy link
Copy Markdown
Contributor

@splitinfinities splitinfinities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

@rwaskiewicz rwaskiewicz marked this pull request as ready for review October 6, 2021 20:57
@rwaskiewicz rwaskiewicz requested a review from a team October 6, 2021 20:57
@rwaskiewicz rwaskiewicz merged commit e17b915 into main Oct 7, 2021
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/rename-master-to-main-in-core branch October 7, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants