protocol: Add serialization support for topic filters#427
Merged
Conversation
urvisavla
reviewed
May 7, 2025
tamirms
reviewed
May 7, 2025
urvisavla
reviewed
May 13, 2025
urvisavla
reviewed
May 13, 2025
urvisavla
approved these changes
May 14, 2025
2opremio
pushed a commit
to 2opremio/soroban-rpc
that referenced
this pull request
May 21, 2025
2opremio
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow
SegmentFilters to be serializable for client SDK usage.Why
Closes #404
Known Limitations
This will have to be updated for Protocol 23 due to #419, but I'm targeting
mainso we can tag that off faster to unblock clients.