getledgerentry endpoint for RPC#4721
Merged
SirTyson merged 2 commits intostellar:masterfrom May 19, 2025
Merged
Conversation
6 tasks
Member
leighmcculloch
left a comment
There was a problem hiding this comment.
👏🏻 Reviewing just the command doc.
dmkozh
reviewed
May 13, 2025
Contributor
Author
|
I should have addressed all y'alls comments and unified the interfaces. |
dmkozh
previously approved these changes
May 14, 2025
Shaptic
reviewed
May 15, 2025
Shaptic
reviewed
May 15, 2025
Shaptic
approved these changes
May 15, 2025
Shaptic
left a comment
There was a problem hiding this comment.
Reviewed docs, not code, but API looks good!
Shaptic
added a commit
to stellar/go-stellar-sdk
that referenced
this pull request
May 15, 2025
dmkozh
approved these changes
May 19, 2025
Shaptic
added a commit
to stellar/go-stellar-sdk
that referenced
this pull request
May 21, 2025
) * Update fields to coincide with stellar/stellar-core#4721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an HTTP endpoint that can query ledger state and provide an entry's archival status. This can be used by RPC for preflighting TXs without needing to maintain a redundant ledger state database. The endpoint API can be found in
docs/software/commands.md.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)