overlay tech debt: flow control#3686
Merged
latobarita merged 4 commits intostellar:masterfrom Apr 20, 2023
Merged
Conversation
8d1b2f7 to
4290a2b
Compare
SirTyson
approved these changes
Apr 19, 2023
Contributor
SirTyson
left a comment
There was a problem hiding this comment.
LGTM with a few typos and minor cleanups.
src/overlay/FlowControl.cpp
Outdated
Contributor
There was a problem hiding this comment.
Nit: Any reason for C style cast here but static_cast below?
Contributor
Author
There was a problem hiding this comment.
ah, this was copy pasta from elsewhere. Updated this function to use static_cast.
src/overlay/FlowControl.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
Done (other functions too)
src/overlay/Peer.cpp
Outdated
src/overlay/FlowControl.h
Outdated
src/overlay/FlowControl.h
Outdated
src/overlay/FlowControl.h
Outdated
src/overlay/FlowControlCapacity.h
Outdated
src/overlay/FlowControlCapacity.h
Outdated
graydon
approved these changes
Apr 20, 2023
Contributor
graydon
left a comment
There was a problem hiding this comment.
Quick skim (and sense that this is a no-op / refactor) LGTM
ed3dce1 to
ea98ae2
Compare
ea98ae2 to
11fcc58
Compare
mbsdf
approved these changes
Apr 20, 2023
Contributor
|
r+ 11fcc58 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3676
First pass at decoupling Peer class into separate modules to ease code reviewing and testing. For now, I kept the tests as-is, but in the next iteration it'd be nice to audit and cleanup tests as well (maybe when we add bytes accounting). Specifically, it should now be easier to test flow-control-specific functionality (capacity accounting, outbound queuing, outbound purging etc) in an isolated way without depending on the internals of Peer/Application.