RequestManager: add support for fetching Blobs#4844
Merged
Conversation
Contributor
|
https://ci.status.im/job/nimbus-eth2/job/platforms/job/macos/job/aarch64/job/PR-4844/2/consoleText |
tersec
reviewed
Apr 21, 2023
tersec
reviewed
Apr 21, 2023
tersec
reviewed
Apr 21, 2023
tersec
reviewed
Apr 23, 2023
tersec
reviewed
Apr 23, 2023
Contributor
Author
|
A side note: this is PR #4844. 😎 |
etan-status
added a commit
that referenced
this pull request
May 16, 2026
- #4732 KZG primitives added - #4785 added gossip validation for BlobSidecar but did not check KZG - #4844 added req/resp for BlobSidecar but did not validate responses - #5445 fixed KZG validate_blobs in state transition (Opt[bool] jank) - ethereum/consensus-specs#3531 new spec hits - #5565 new spec, + fixed gossip missing inclusion proof + KZG checks - #6109 goerli hardening, + fixed Req/Resp missing inclusion proof check - #6741 copies the req/resp gap to Fulu - #8254 removes the Deneb blob_quarantine - This one now finally adds the missing KZG checks to req/resp
etan-status
added a commit
that referenced
this pull request
May 16, 2026
- #4732 KZG primitives added - #4785 added gossip validation for BlobSidecar but did not check KZG - #4844 added req/resp for BlobSidecar but did not validate responses - #5445 fixed KZG validate_blobs in state transition (Opt[bool] jank) - ethereum/consensus-specs#3531 new spec hits - #5565 new spec, + fixed gossip missing inclusion proof + KZG checks - #6109 goerli hardening, + fixed Req/Resp missing inclusion proof check - #6741 copies the remaining req/resp missing KZG check gap to Fulu - #8254 removes the Deneb blob_quarantine - This one now finally adds the missing KZG checks to req/resp
tersec
pushed a commit
that referenced
this pull request
May 17, 2026
- #4732 KZG primitives added - #4785 added gossip validation for BlobSidecar but did not check KZG - #4844 added req/resp for BlobSidecar but did not validate responses - #5445 fixed KZG validate_blobs in state transition (Opt[bool] jank) - ethereum/consensus-specs#3531 new spec hits - #5565 new spec, + fixed gossip missing inclusion proof + KZG checks - #6109 goerli hardening, + fixed Req/Resp missing inclusion proof check - #6741 copies the remaining req/resp missing KZG check gap to Fulu - #8254 removes the Deneb blob_quarantine - This one now finally adds the missing KZG checks to req/resp
tersec
pushed a commit
that referenced
this pull request
May 17, 2026
- #4844 added BlobSidecar req/resp, no resp length check - #6741 copies logic to data column, also no resp length check - #6954 infra to check resp length - #6961 add resp length check for blobs, but not for in development cols - #8254 removed blob support, resp length check now gone - Now: Add resp length check for all requests with list responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.