Make statsd work with newer version of node#565
Merged
coykitten merged 3 commits intostatsd:masterfrom Mar 17, 2016
Merged
Conversation
|
Any proposed date for merging? Really need this |
|
+1 To prioritize this merge. It should be a quick merge since it's a simple fix and it prevents statsd from breaking on a newer nodejs env. |
coykitten
added a commit
that referenced
this pull request
Mar 17, 2016
Makes statsd work with newer versions of node
Contributor
|
Apologies on the wait. Looking to cut a new version soon with these changes on npm. Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-syslog doesn't work with newer node.js versions and it's website says it not supported, so changed this dependency to modern-syslog library.
https://github.com/schamane/node-syslog
nodeunit 0.7.x doesn't compatible with newer node.js versions, so an update was required.
caolan/nodeunit#291