Eloquent OAuth #2901
Merged
Eloquent OAuth #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes OAuth when the Eloquent driver is enabled.
The file based auth stuff works just as well for Eloquent, so just moved that to the abstract repo. If someone wants to put columns in their users table, they're welcome to make a migration and override the method on their own repo.
As pointed out in #2879, there's an error where Laravel tries to access the timestamps property. Rather than make a property that just doesn't do anything, it'll now pass it along to the actual model.
Fixes #2388
Closes #2879