Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TomerStarkware
approved these changes
Feb 11, 2026
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 16 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Simplified the event deserialization code by removing intermediate variables and directly inlining deserialization calls. This refactoring reduces code verbosity while maintaining the same functionality. Additionally it removes the possible shadowing of vars by the macro generated code.
Type of change
Please check one:
Why is this change needed?
The event deserialization code was unnecessarily verbose, with multiple intermediate variables and separate functions that made the code harder to read and maintain. This change streamlines the code by directly using the deserialization results where needed, making the generated code more concise.
What was the behavior or documentation before?
Previously, the code would generate separate statements for deserializing each field and then use those variables in the constructor. For example:
What is the behavior or documentation after?
Now, the deserialization is inlined directly in the struct initialization, making the code more concise:
Additional context
This change introduces a new helper function
deserialize_member_codethat returns the appropriate deserialization code string based on the field kind, which is then used directly in the struct initialization. This approach reduces code duplication and makes the generated code more maintainable.