Conversation
This was referenced Jan 27, 2026
|
This change is |
5 tasks
Collaborator
Author
5 tasks
eytan-starkware
approved these changes
Jan 27, 2026
Contributor
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @TomerStarkware).
SIERRA_UPDATE_PATCH_CHANGE_TAG=Internal change only.
8f204b9 to
7ddbf0e
Compare
dfafadc to
4071973
Compare
orizi
commented
Jan 27, 2026
Collaborator
Author
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed unused helper functions
core_libfunc_postcostandcore_libfunc_precostfrom the Sierra gas module, and inlined their functionality directly into the calling functions incore_libfunc_cost_expr.rs. This simplifies the codebase by eliminating deprecated functions that were marked with TODOs for removal.Type of change
Please check one:
Why is this change needed?
The codebase contained deprecated helper functions that were marked with TODOs for removal. These functions were intermediaries that added unnecessary complexity. By removing them and inlining their functionality directly where needed, we simplify the code and potentially improve performance by eliminating function call overhead.
What was the behavior or documentation before?
The code used two helper functions (
core_libfunc_postcostandcore_libfunc_precost) that were marked with TODOs for removal, indicating they were deprecated but still in use.What is the behavior or documentation after?
The functionality of these helper functions has been inlined directly into the calling functions in
core_libfunc_cost_expr.rs, maintaining the same behavior while simplifying the codebase.