Conversation
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3e91bbe to
fb98e09
Compare
5 tasks
* Some by a minor fix * Some because no longer relevant, since solved or outdated.
fb98e09 to
fe467e0
Compare
This was referenced Dec 25, 2025
eytan-starkware
approved these changes
Dec 28, 2025
Contributor
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 12 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware).
eytan-starkware
approved these changes
Dec 28, 2025
Contributor
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware made 1 comment.
Reviewable status:
TomerStarkware
approved these changes
Dec 28, 2025
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:
Princetimix69
pushed a commit
to Princetimix69/cairo
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up TODOs and improves code quality in several ways:
box.cairoabout function exposureEcPointAddimplementation by replacing nested match statements with more conciseif letsyntaxConstPowHelperimplementations with a macro to reduce code duplicationResOperand::to_res_description()to properly handle BigInt valuesType of change
Please check one:
Why is this change needed?
This PR addresses several issues:
EcPointAddimplementation had verbose and potentially error-prone nested match statementsConstPowHelperimplementations were duplicated for each numeric type, making maintenance difficultWhat was the behavior or documentation before?
EcPointAddused nested match statements for control flowConstPowHelperhad separate, duplicated implementations for each numeric typeWhat is the behavior or documentation after?
EcPointAddnow uses cleanerif letsyntaxConstPowHelperimplementations are generated using a macroAdditional context
This PR is primarily focused on code cleanup and maintenance, removing technical debt and improving code quality without changing functionality.