Conversation
This was referenced Dec 23, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
Arcticae
approved these changes
Dec 23, 2025
Collaborator
Arcticae
left a comment
There was a problem hiding this comment.
@Arcticae made 1 comment.
Reviewable status: 0 of 141 files reviewed, all discussions resolved (waiting on @TomerStarkware).
2485b95 to
85cf3a0
Compare
9f720ec to
230e33a
Compare
85cf3a0 to
6265814
Compare
230e33a to
0e2e149
Compare
6265814 to
a1877ef
Compare
0e2e149 to
b77cad2
Compare
TomerStarkware
approved these changes
Dec 23, 2025
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 141 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi).
Princetimix69
pushed a commit
to Princetimix69/cairo
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added error-codes for all diagnostics, while leaving space to lower numbers for diagnostics with specific handling.
Type of change
Please check one:
Why is this change needed?
Easier classification of diagnostics by automatic tools.
What was the behavior or documentation before?
Most didn't have an error code.
What is the behavior or documentation after?
All have some error code.