Conversation
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/ecdsa.cairo line 202 at r1 (raw file):
/// Checks if `value != 0` (mod stark_curve::ORDER). fn is_equivalent_to_zero(value: felt252) -> bool { value == 0 || value == ec::stark_curve::ORDER
Suggestion:
// Note that 2*ec::stark_curve::ORDER > felt252 PRIME
value == 0 || value == ec::stark_curve::ORDER
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
2f8b0cb to
1e95f95
Compare
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)

No description provided.