Skip to content

Refactored s check and improved failure in recover_public_key.#9142

Merged
orizi merged 1 commit intomainfrom
orizi/12-17-refactored_s_check_and_improved_failure_in_recover_public_key_
Dec 17, 2025
Merged

Refactored s check and improved failure in recover_public_key.#9142
orizi merged 1 commit intomainfrom
orizi/12-17-refactored_s_check_and_improved_failure_in_recover_public_key_

Conversation

@orizi
Copy link
Collaborator

@orizi orizi commented Dec 17, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

orizi commented Dec 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@orizi orizi marked this pull request as ready for review December 17, 2025 11:15
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/ecdsa.cairo line 202 at r1 (raw file):

/// Checks if `value != 0` (mod stark_curve::ORDER).
fn is_equivalent_to_zero(value: felt252) -> bool {
    value == 0 || value == ec::stark_curve::ORDER

Suggestion:

 // Note that 2*ec::stark_curve::ORDER > felt252 PRIME
 value == 0 || value == ec::stark_curve::ORDER

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ilyalesokhin-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi force-pushed the orizi/12-17-refactored_s_check_and_improved_failure_in_recover_public_key_ branch from 2f8b0cb to 1e95f95 Compare December 17, 2025 11:22
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyalesokhin-starkware reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)

@orizi orizi enabled auto-merge December 17, 2025 11:31
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit f3ea4aa Dec 17, 2025
54 checks passed
@orizi orizi deleted the orizi/12-17-refactored_s_check_and_improved_failure_in_recover_public_key_ branch December 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants