Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
60b2dff to
764b116
Compare
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)
crates/cairo-lang-semantic/src/expr/test_data/deref line 208 at r2 (raw file):
//! > ========================================================================== //! > Final deref return values should decide the number of snapshots.
Please add a test with more then one snapshot, and with a more intiricate deref path w/wo snapshots
764b116 to
d5af869
Compare
orizi
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware)
crates/cairo-lang-semantic/src/expr/test_data/deref line 208 at r2 (raw file):
Previously, eytan-starkware wrote…
Please add a test with more then one snapshot, and with a more intiricate deref path w/wo snapshots
regarding intricate paths without snapshots - these are basically the existing tests.
the "intiricacy of the path" is already tested.
added multiple snapshots.
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
No description provided.