Added const for EcPoint including non-zero.#8750
Conversation
|
This change is |
107388f to
9dcfe93
Compare
Added actual usage of it in ECDSA - blocked by cfg. SIERRA_UPDATE_PATCH_CHANGE_TAG=Extending an existing libfunc option.
9dcfe93 to
341a23a
Compare
|
Does this check if the point is on the curve? Code quote: AffinePoint::new(Felt252::from(x), Felt252::from(y)) |
|
what does this do? Code quote: cfg(sierra: "future") |
orizi
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @TomerStarkware)
corelib/src/ecdsa.cairo line 217 at r2 (raw file):
Previously, ilyalesokhin-starkware wrote…
what does this do?
just hides the rest of the unused code.
orizi
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @TomerStarkware)
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 242 at r2 (raw file):
Previously, ilyalesokhin-starkware wrote…
Does this check if the point is on the curve?
yes - that is the exact error type.
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
liorgold2
left a comment
There was a problem hiding this comment.
@liorgold2 reviewed 1 file and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions.
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 188 at r2 (raw file):
return Ok(()); } [GenericArg::Value(_x), GenericArg::Value(y)] if !y.is_zero() => {
Let's discuss this f2f.
(check EcPoint first + return error if y is zero)
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 226 at r2 (raw file):
} /// Given a
Fix doc.
Code quote:
/// Given acrates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 228 at r2 (raw file):
/// Given a fn validate_const_ec_data( _context: &dyn TypeSpecializationContext,
Remove _context parameter.
orizi
left a comment
There was a problem hiding this comment.
@orizi made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions.
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 188 at r2 (raw file):
Previously, liorgold2 wrote…
Let's discuss this f2f.
(check EcPoint first + return error if y is zero)
basically in all these options - i prefer the option that does not require reading the context to fail, before i fail.
otherwise i need to always call the get_type_info.
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 226 at r2 (raw file):
Previously, liorgold2 wrote…
Fix doc.
Done.
crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 228 at r2 (raw file):
Previously, liorgold2 wrote…
Remove
_contextparameter.
Done.
a discussion (no related file):
https://reviewable.io/reviews/starkware-libs/cairo/9380
Added actual usage of it in ECDSA - blocked by cfg.