Skip to content

build(dependabot): ignore non-major action updates#1752

Merged
voxpelli merged 2 commits intomasterfrom
build/dependabot
Nov 29, 2021
Merged

build(dependabot): ignore non-major action updates#1752
voxpelli merged 2 commits intomasterfrom
build/dependabot

Conversation

@voxpelli
Copy link
Copy Markdown
Member

@voxpelli voxpelli commented Nov 29, 2021

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

Improvement of maintenance setup

What changes did you make? (Give an overview)

Follow the lead of fastify/fastify#3451

No need to add the PR noise of every little patch or minor update to official GitHub actions. That just creates alert fatigue and drowns out actually substantial and/or important PR:s.

Which issue (if any) does this pull request address?

Solves fastify/fastify#3451, but for standard/standard

Is there anything you'd like reviewers to focus on?

Whether there are any objections to this change (and whether I have forgotten to widen an action range somewhere)

Follow the lead of fastify/fastify#3451

No need to add the PR noise of every little patch or minor update to official GitHub actions. That just creates alert fatigue and drowns out actually substantial and/or important PR:s.
Copy link
Copy Markdown
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@voxpelli voxpelli merged commit 605fb5c into master Nov 29, 2021
@voxpelli voxpelli deleted the build/dependabot branch November 29, 2021 16:02
voxpelli added a commit to standard/standard-engine that referenced this pull request Nov 29, 2021
voxpelli added a commit to standard/standard-engine that referenced this pull request Nov 29, 2021
voxpelli added a commit to standard/standard-engine that referenced this pull request Nov 30, 2021
* Validate engine versions + dependency list

* Probably make all pass

* Fix failing tests

* Fix Node 12 support

* Remove leftover todo comment

* Improve naming of "results" post refactoring

* Extract `hasErrors` and `hasWarnings` variables

* Add coverage report

* Exclude tests from type checks

As else it checks `tmp/standard/`, which doesn't pass

* Tweak type format

* Extract utility methods

* Remove non-needed @ts-ignore

* Add unit tests for utils

* We need to ensure we run the clone test first

* Rename `build` to `lint`

* Rename `Linter` to `StandardEngine`

* Update README + CHANGELOG

* Sync `dependabot.yml` with standard/standard repo

See standard/standard#1752

* Update CHANGELOG.md

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants