Default skills to the "default" group on install#4201
Merged
Conversation
Workloads already default to the "default" group when no group is specified (pkg/api/v1/workload_service.go), but skills did not. When `thv skill install <name>` was called without --group, the group field stayed empty and registerSkillInGroup was a no-op, meaning skills were never added to any group unless explicitly requested. Add the same defaulting logic in the skill service Install method so that skills are automatically registered in the "default" group, matching workload behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4201 +/- ##
==========================================
- Coverage 69.04% 68.92% -0.13%
==========================================
Files 468 468
Lines 47003 47032 +29
==========================================
- Hits 32453 32415 -38
- Misses 11974 11977 +3
- Partials 2576 2640 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
amirejaz
reviewed
Mar 18, 2026
Contributor
amirejaz
left a comment
There was a problem hiding this comment.
If the skills are being used by folks with thv we need to have migration moving existing non-group skills to default group.
Collaborator
Author
|
@amirejaz skills are not yet exposed. All commands are hidden and we haven't been promoting them yet. |
amirejaz
approved these changes
Mar 18, 2026
Sanskarzz
pushed a commit
to Sanskarzz/toolhive
that referenced
this pull request
Mar 23, 2026
Workloads already default to the "default" group when no group is specified (pkg/api/v1/workload_service.go), but skills did not. When `thv skill install <name>` was called without --group, the group field stayed empty and registerSkillInGroup was a no-op, meaning skills were never added to any group unless explicitly requested. Add the same defaulting logic in the skill service Install method so that skills are automatically registered in the "default" group, matching workload behavior. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workloads already default to the "default" group when no group is specified
(
pkg/api/v1/workload_service.go), but skills did not. Whenthv skill install <name>was called without--group, the group field stayedempty and
registerSkillInGroupwas a no-op, meaning skills were never added toany group unless the user explicitly passed
--group.Installmethod so skillsare automatically registered in the "default" group, matching workload behavior
Type of change
Test plan
task test)task lint-fix)Does this introduce a user-facing change?
Skills installed without
--groupare now automatically added to the "default"group, matching the existing behavior for workloads. Previously they were not
added to any group.
Generated with Claude Code