Merged
Conversation
jhrozek
previously approved these changes
Mar 18, 2026
c018186 to
106298e
Compare
jhrozek
previously approved these changes
Mar 18, 2026
jhrozek
previously approved these changes
Mar 18, 2026
Move ByteSize from pkg/domain/config/ to pkg/domain/bytesize/ so that pkg/domain/agent/ can use it without creating a circular import. Change Agent.DefaultMemory and DefaultTmpSize from uint32 to bytesize.ByteSize, eliminating the MiB() conversion ping-pong in config.Merge(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
VMConfig.Memory and TmpSize now use bytesize.ByteSize instead of raw uint32. The .MiB() conversion moves to internal/infra/vm/ where go-microvm actually needs the integer, keeping the domain/application layers working with the richer type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update config_test.go to use bytesize.ByteSize instead of bare ByteSize after the type was moved to its own package. Also update DefaultTmpSize test values to 2048 MiB to match the upstream change.
70e8e38 to
15954f1
Compare
jhrozek
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ByteSizetype frompkg/domain/config/to newpkg/domain/bytesize/leaf packageagent.Agent.DefaultMemoryandDefaultTmpSizefromuint32tobytesize.ByteSizeconfig.Merge()by eliminating theByteSize↔uint32conversion ping-pongThis resolves the circular import blocker (
config → agentalready exists, soagent → configwould cycle). The newpkg/domain/bytesize/package is a leaf with no domain imports, keeping the dependency graph clean:Follow-up from PR #60 review feedback.
Test plan
task fmtpassestask lintpassestask testpasses — all existing tests updated and greengo build ./...fails immediately on cycles)🤖 Generated with Claude Code