Conversation
Memory (RAM) for VMs was configured as raw uint32 in MiB while tmp_size already used the human-readable ByteSize type. This unifies them so users write `memory: "4g"` instead of `memory: 4096`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jhrozek
reviewed
Mar 17, 2026
Contributor
jhrozek
left a comment
There was a problem hiding this comment.
Clean change, consistent with the tmp_size pattern. A couple of small things inline.
jhrozek
approved these changes
Mar 17, 2026
Contributor
jhrozek
left a comment
There was a problem hiding this comment.
Looks good — the inline comments are just nits, fine to fix later.
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultsConfig.MemoryandAgentOverride.Memoryfromuint32toByteSize, matching the existingTmpSizepattern--memoryCLI flag fromUint32VartoStringVarwithParseByteSize(), so users write--memory 4ginstead of--memory 4096MaxMemoryconstant toByteSizeand adaptclampResources()andMerge()accordingly"4g","512m")Bare integers in YAML config are still accepted (backward compatible via
ByteSize.UnmarshalText).Test plan
task fmt && task lint— 0 issuestask test— all tests passbbox claude-code --memory 4gworksmemory: "4g"in config.yaml worksmemory: 4096still works (backward compat)🤖 Generated with Claude Code