Skip to content

chore(ci): use fedora:33 instead of fedora:latest#14

Merged
ssut merged 1 commit into
ssut:mainfrom
luk1337:patch-3
Apr 28, 2021
Merged

chore(ci): use fedora:33 instead of fedora:latest#14
ssut merged 1 commit into
ssut:mainfrom
luk1337:patch-3

Conversation

@luk1337

@luk1337 luk1337 commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Apparently F34 became latest couple hours ago and
thus Darwin builds fail now.

@luk1337

luk1337 commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

Kinda unlucky. You can merge once https://github.com/luk1337/payload-dumper-go/actions/runs/791045120 succeeds.

Apparently F34 became `latest` couple hours ago and
thus Darwin builds fail now.
@luk1337 luk1337 changed the title chore(ci): Use fedora:33 instead of fedora:latest chore(ci): use fedora:33 instead of fedora:latest Apr 28, 2021
@luk1337

luk1337 commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

Looks like #13 fixed -dynamic linker flag issue but we'd need newer macos sdk since F34 has golang >1.14
But #13 + #14 works so you can go ahead and merge both changes and then retag 1.1.0.

@ssut ssut merged commit 9378850 into ssut:main Apr 28, 2021
@ssut

ssut commented Apr 28, 2021

Copy link
Copy Markdown
Owner

Nice work! Thank you.

@luk1337

luk1337 commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

I'll look into fetching current macos sdk in separate job similarly to here — https://github.com/itamae-kitchen/mitamae/blob/master/.github/workflows/build.yml#L59-L74 later on. That should let us also build Darwin/ARM64 and upgrade to newer golang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants