Merged
Conversation
Closed
Contributor
Author
|
Also, bump lookout-sdk-ml version |
vmarkovtsev
approved these changes
Feb 1, 2019
Collaborator
|
@zurk you need to change the version in a few other places |
I need this fix src-d/lookout#409 to make this PR work: src-d/style-analyzer#562 Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Contributor
Author
|
@vmarkovtsev done |
vmarkovtsev
approved these changes
Feb 1, 2019
Collaborator
|
@zurk According to semver, 0.x.y - y should be incremented for non-breaking API changes, and x for the others. So here we should have gone with 0.8.2. But anyway, since it is 0.*, it is not critical so I merged. |
Contributor
Author
|
ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this fix src-d/lookout#409
to make this PR work: src-d/style-analyzer#562