Fix GetChanges issue with changes in both sides#600
Open
dpordomingo wants to merge 3 commits intosrc-d:masterfrom
Open
Fix GetChanges issue with changes in both sides#600dpordomingo wants to merge 3 commits intosrc-d:masterfrom
dpordomingo wants to merge 3 commits intosrc-d:masterfrom
Conversation
…idate Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Contributor
Author
|
Travis is failing at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #486
depends on src-d/go-git#1097
depends on src-d/go-git-fixtures#13supersedes #530
This PR fix #486, so when an analyzer reviews the PR of
get-changes-from-outdated-pr-candidateagainstget-changes-from-outdated-pr, it should not fail (as it's currently happening here)breaking changes
DataService.GetChangesis currently returning the differences betweenbaseandhead, so when this is merged, it will return the differences betweengit merge-base base headandhead.In case any analyzer wants to get the changes between
baseandheadit should configure theChangeRequest.TwoDotsMode, astrueas described by src-d/lookout-sdk#76