Modify proto with ChangeRequest.TwoDotsMode#76
Open
dpordomingo wants to merge 1 commit intosrc-d:masterfrom
Open
Modify proto with ChangeRequest.TwoDotsMode#76dpordomingo wants to merge 1 commit intosrc-d:masterfrom
dpordomingo wants to merge 1 commit intosrc-d:masterfrom
Conversation
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
carlosms
approved these changes
Feb 25, 2019
Contributor
carlosms
left a comment
There was a problem hiding this comment.
👍
But let's wait for src-d/lookout#530 to be finished before we merge and release this one.
Contributor
Author
|
It would be great if we could release this before merging src-d/lookout#530 to see Travis pass 💃 |
Contributor
|
Sorry, I didn't mean to merge src-d/lookout#530 before this one. What I meant is to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocks src-d/lookout#530
In order to show the same changes than appear in
Changestab from GitHub PRs, the standard behavior forDataService.GetChangesis returning the changes as if doinggit diff base...head(what works asgit diff $(git merge-base base head) head)If the analyzer wants all changes between
baseandhead, (as done bygit diff base..head) it must sendTwoDotsModeas true in theChangesRequest.