Open
Conversation
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Merged
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
8b9db32 to
a2a9748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caused by #488
This PR adds a
commentsfield to the logger, so when error is logged, it will appear the offending comments.ERROR event processing failed app=lookout event-id=b44c158d09bebb40b85ce23763dd9ab179926019 event-type=*pb.ReviewEvent github.pr=63 head=refs/pull/63/head repo=https://github.com/dpordomingo/testing-repo.git error=posting analysis failed: github api error: review could not be pushed: POST https://api.github.com/repos/dpordomingo/testing-repo/pulls/63/reviews 422 Unprocessable Entity [{Resource:Review Message:Path is invalid }] comments={commit:4718b67c9a53d95cd53c6da8d25e5e990a1752a1 body: event:COMMENT comments:[ {path:README.md pos:1 body:language: Markdown} {path:golang.go pos:1 body:language: Go} ... ]}benefits
these ☝️ new details would have been really useful when debugging #486
cons
Arised by @carlosms:
#488 (comment)
#488 (comment)