Merged
Conversation
carlosms
reviewed
Jan 24, 2019
carlosms
reviewed
Jan 24, 2019
carlosms
reviewed
Jan 24, 2019
55cb74a to
eacee66
Compare
Contributor
Author
|
As I said #488 (comment) I moved the disputed commit to a new PR #492 so the enhancements proposed by this one wont be blocked 🗡️ |
carlosms
reviewed
Jan 28, 2019
carlosms
approved these changes
Jan 28, 2019
Contributor
carlosms
left a comment
There was a problem hiding this comment.
👍 with the change in the error message
7cc399a to
e122fbe
Compare
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
e122fbe to
accc8f4
Compare
Contributor
Author
|
I have no clue about why integration tests are now failing... |
Contributor
Author
|
I saw it's already failing in |
Contributor
Author
|
And it is now passing. |
Contributor
|
It's probably because of #490. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #487
before:
problems:
PANICwithout traceafter
ERROR event processing failed .... (same data as before changes) error=posting analysis failed: github api error: review could not be pushed: POST https://api.github.com/repos/dpordomingo/testing-repo/pulls/63/reviews 422 Unprocessable Entity [{Resource:Review Message:Path is invalid }]benefits:
these ☝️ new details would have been really useful when debugging #486
cons:
handleAPIErrorcould be done directly ingoogle/go-githubproject, but it should be considered separately, so I'd handle it in a google/go-github PR