feature: make lookout-sdk return error code if analysis failed#411
Merged
smacker merged 3 commits intosrc-d:masterfrom Dec 13, 2018
smacker:lookout_sdk_bin_exit_code
Merged
feature: make lookout-sdk return error code if analysis failed#411smacker merged 3 commits intosrc-d:masterfrom smacker:lookout_sdk_bin_exit_code
smacker merged 3 commits intosrc-d:masterfrom
smacker:lookout_sdk_bin_exit_code
Conversation
I have rewritten concurrentRequest function using channels to be able to exit as soon as the first analyzer failed. commentList is also replaced with channel because it's weird to mix sync package and channels in one function. fix: #409 Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
reviewed
Dec 12, 2018
carlosms
reviewed
Dec 13, 2018
dpordomingo
approved these changes
Dec 13, 2018
| pushTimeout time.Duration, | ||
| ) *Server { | ||
| return &Server{p, fileGetter, analyzers, eventOp, commentOp, reviewTimeout, pushTimeout} | ||
| return &Server{false, p, fileGetter, analyzers, eventOp, commentOp, reviewTimeout, pushTimeout} |
Contributor
There was a problem hiding this comment.
I'm late in the discussion... but... I'd prefer not to use positional arguments.
Contributor
Author
There was a problem hiding this comment.
sorry David but it's unrelated to this PR. It uses the same style that was used before. We can fix it in another PR later if you want.
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Contributor
Author
|
I updated the failing test also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have rewritten concurrentRequest function using channels to be able to
exit as soon as the first analyzer failed.
commentList is also replaced with channel because it's weird to mix
sync package and channels in one function.
fix: #409
Signed-off-by: Maxim Sukharev max@smacker.ru