PHP 8.2 | File::getClassProperties(): add support for readonly classes#3686
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom May 18, 2023
Conversation
PHP 8.2 introduces `readonly` classes. The `readonly` keyword can be combined with the `abstract` or `final` keyword. See: https://3v4l.org/VIXgD Includes adding a full set of tests for the `File::getClassProperties()` method, which was so far untested. Ref: * https://wiki.php.net/rfc/readonly_classes
Contributor
Author
|
FYI: I have follow-up commits ready for 11 sniffs to take readonly classes into account. |
5 tasks
10 tasks
Contributor
Author
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.2 introduces
readonlyclasses. Thereadonlykeyword can be combined with theabstractorfinalkeyword. See: https://3v4l.org/VIXgDIncludes adding a full set of tests for the
File::getClassProperties()method, which was so far untested.Ref: