Squiz/OperatorBracket: fix regression for new parent#3671
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Sep 22, 2022
Merged
Conversation
Related to 3546 which fixed an inconsistency after 3484. The change of the tokenization from `T_STRING` to `T_PARENT` for the `parent` keyword caused a regression in the `Squiz.Formatting.OperatorBracket` sniff. Fixed now. Includes unit tests.
Contributor
Author
|
Looks like something wonky is going on with Packagist I suppose retriggering the build at a later moment in time should fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3546 which fixed an inconsistency after #3484.
The change of the tokenization from
T_STRINGtoT_PARENTfor theparentkeyword caused a regression in theSquiz.Formatting.OperatorBracketsniff.Fixed now.
Includes unit tests.