Squiz/ScopeClosingBrace: bug fix - prevent removing inline HTML when fixing#3447
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Nov 1, 2021
Conversation
…fixing When non-empty inline HTML is on the same line, before the scope closing, the sniff would incorrectly throw the `Closing brace indented incorrectly; expected %s spaces, found %s` error, instead of the `Closing brace must be on a line by itself` error. This would ultimately lead to the fixer removing the non-empty inline HTML, potentially breaking HTML display/structure. Fixed now. Includes unit test. Fixes 3422
Member
|
Thanks a lot for fixing this. Assuming inline HTML is always empty was not some of my best work... |
Contributor
Author
Well, the original sniff is pretty ancient (from the initial import), so from well before the fixer functionality was available, so not that surprising that something like this slipped through the cracks. What is surprising is that no other bug reports about this had been filed in the seven years since the fixers got added 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When non-empty inline HTML is on the same line, before the scope closing, the sniff would incorrectly throw the
Closing brace indented incorrectly; expected %s spaces, found %serror, instead of theClosing brace must be on a line by itselferror.This would ultimately lead to the fixer removing the non-empty inline HTML, potentially breaking HTML display/structure.
Fixed now. Includes unit test.
Fixes #3422