WSL support: replace remaining calls to is_readable()#3428
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Nov 1, 2021
Merged
WSL support: replace remaining calls to is_readable()#3428gsherwood merged 1 commit intosquizlabs:masterfrom
is_readable()#3428gsherwood merged 1 commit intosquizlabs:masterfrom
Conversation
... with calls to `Common::isReadable()` as introduced in d56e167 . Includes adding additional error silencing to the `Common::isReadable()` function as each of these PHP native functions will throw a warning upon failure. Co-authored-by: Graham Wharton <graham@gwharton.me.uk> Fixes 3388 May also fix 3412, but needs testing.
Contributor
Author
|
Note: commit contains co-author details for credits. |
This was referenced Sep 6, 2021
gsherwood
added a commit
that referenced
this pull request
Nov 1, 2021
Member
|
Thanks for fixing those calls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... with calls to
Common::isReadable()as introduced in d56e167 .Includes adding additional error silencing to the
Common::isReadable()function as each of these PHP native functions will throw a warning upon failure.Fixes #3388